Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add redis-compress flag to argocd admin dashboard command (#13055) #13056

Merged
merged 10 commits into from
Apr 4, 2023

Conversation

aborilov
Copy link
Contributor

@aborilov aborilov commented Mar 30, 2023

Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard.

Fixes: #13055

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (696631e) 49.06% compared to head (8174a8e) 49.05%.

❗ Current head 8174a8e differs from pull request most recent head d9a2efe. Consider uploading reports for the commit d9a2efe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13056      +/-   ##
==========================================
- Coverage   49.06%   49.05%   -0.01%     
==========================================
  Files         246      246              
  Lines       42561    42565       +4     
==========================================
  Hits        20881    20881              
- Misses      19565    19569       +4     
  Partials     2115     2115              
Impacted Files Coverage Δ
cmd/argocd/commands/admin/dashboard.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
aborilov and others added 3 commits March 31, 2023 00:05
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
@aborilov
Copy link
Contributor Author

@crenshaw-dev is it ok to merge this PR?

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local test checks out. Thanks, @aborilov!

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

@crenshaw-dev crenshaw-dev merged commit 381fed5 into argoproj:master Apr 4, 2023
21 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 4, 2023
…nd (#13055) (#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 4, 2023
…nd (#13055) (#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 4, 2023
…nd (#13055) (#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
alexmt pushed a commit that referenced this pull request Apr 6, 2023
…nd (#13055) (#13056) (#13116)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.



* update dashboard docs for --redis-compress flag



* add support for REDIS_COMRESSION env in cli admin dashboard



* update flag description




* update dashboard docs



---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
alexmt pushed a commit that referenced this pull request Apr 6, 2023
…nd (#13055) (#13056) (#13115)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.



* update dashboard docs for --redis-compress flag



* add support for REDIS_COMRESSION env in cli admin dashboard



* update flag description




* update dashboard docs



---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
alexmt pushed a commit that referenced this pull request Apr 6, 2023
…nd (#13055) (#13056) (#13114)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.



* update dashboard docs for --redis-compress flag



* add support for REDIS_COMRESSION env in cli admin dashboard



* update flag description




* update dashboard docs



---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
…nd (argoproj#13055) (argoproj#13056) (argoproj#13114)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

* update dashboard docs for --redis-compress flag

* add support for REDIS_COMRESSION env in cli admin dashboard

* update flag description

* update dashboard docs

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…nd (argoproj#13055) (argoproj#13056)

* add `redis-compress` flag to `argocd admin dashboard` command

Previously, gzip compression was disabled and not configurable,
which made it impossible to work with gzipped Redis cache.
This commit adds support for gzip compression to the ArgoCD admin dashboard.

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update dashboard docs for --redis-compress flag

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* add support for REDIS_COMRESSION env in cli admin dashboard

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

* update flag description

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Pavel <aborilov@gmail.com>

* update dashboard docs

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>

---------

Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI admin dashboard doesn't support redis-compression
2 participants