-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): add redis-compress
flag to argocd admin dashboard
command (#13055)
#13056
fix(cli): add redis-compress
flag to argocd admin dashboard
command (#13055)
#13056
Conversation
Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard. Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #13056 +/- ##
==========================================
- Coverage 49.06% 49.05% -0.01%
==========================================
Files 246 246
Lines 42561 42565 +4
==========================================
Hits 20881 20881
- Misses 19565 19569 +4
Partials 2115 2115
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Pavel <aborilov@gmail.com>
Signed-off-by: Pavel Aborilov <aborilov@gmail.com>
@crenshaw-dev is it ok to merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local test checks out. Thanks, @aborilov!
/cherry-pick release-2.7 |
/cherry-pick release-2.6 |
/cherry-pick release-2.5 |
…nd (#13055) (#13056) * add `redis-compress` flag to `argocd admin dashboard` command Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard. Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * update dashboard docs for --redis-compress flag Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * add support for REDIS_COMRESSION env in cli admin dashboard Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * update flag description Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Pavel <aborilov@gmail.com> * update dashboard docs Signed-off-by: Pavel Aborilov <aborilov@gmail.com> --------- Signed-off-by: Pavel Aborilov <aborilov@gmail.com> Signed-off-by: Pavel <aborilov@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…nd (#13055) (#13056) * add `redis-compress` flag to `argocd admin dashboard` command Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard. Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * update dashboard docs for --redis-compress flag Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * add support for REDIS_COMRESSION env in cli admin dashboard Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * update flag description Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Pavel <aborilov@gmail.com> * update dashboard docs Signed-off-by: Pavel Aborilov <aborilov@gmail.com> --------- Signed-off-by: Pavel Aborilov <aborilov@gmail.com> Signed-off-by: Pavel <aborilov@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…nd (#13055) (#13056) * add `redis-compress` flag to `argocd admin dashboard` command Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard. Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * update dashboard docs for --redis-compress flag Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * add support for REDIS_COMRESSION env in cli admin dashboard Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * update flag description Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Pavel <aborilov@gmail.com> * update dashboard docs Signed-off-by: Pavel Aborilov <aborilov@gmail.com> --------- Signed-off-by: Pavel Aborilov <aborilov@gmail.com> Signed-off-by: Pavel <aborilov@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…nd (#13055) (#13056) (#13116) * add `redis-compress` flag to `argocd admin dashboard` command Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard. * update dashboard docs for --redis-compress flag * add support for REDIS_COMRESSION env in cli admin dashboard * update flag description * update dashboard docs --------- Signed-off-by: Pavel Aborilov <aborilov@gmail.com> Signed-off-by: Pavel <aborilov@gmail.com> Co-authored-by: Pavel <aborilov@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…nd (#13055) (#13056) (#13115) * add `redis-compress` flag to `argocd admin dashboard` command Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard. * update dashboard docs for --redis-compress flag * add support for REDIS_COMRESSION env in cli admin dashboard * update flag description * update dashboard docs --------- Signed-off-by: Pavel Aborilov <aborilov@gmail.com> Signed-off-by: Pavel <aborilov@gmail.com> Co-authored-by: Pavel <aborilov@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…nd (#13055) (#13056) (#13114) * add `redis-compress` flag to `argocd admin dashboard` command Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard. * update dashboard docs for --redis-compress flag * add support for REDIS_COMRESSION env in cli admin dashboard * update flag description * update dashboard docs --------- Signed-off-by: Pavel Aborilov <aborilov@gmail.com> Signed-off-by: Pavel <aborilov@gmail.com> Co-authored-by: Pavel <aborilov@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…nd (argoproj#13055) (argoproj#13056) (argoproj#13114) * add `redis-compress` flag to `argocd admin dashboard` command Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard. * update dashboard docs for --redis-compress flag * add support for REDIS_COMRESSION env in cli admin dashboard * update flag description * update dashboard docs --------- Signed-off-by: Pavel Aborilov <aborilov@gmail.com> Signed-off-by: Pavel <aborilov@gmail.com> Co-authored-by: Pavel <aborilov@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
…nd (argoproj#13055) (argoproj#13056) * add `redis-compress` flag to `argocd admin dashboard` command Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard. Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * update dashboard docs for --redis-compress flag Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * add support for REDIS_COMRESSION env in cli admin dashboard Signed-off-by: Pavel Aborilov <aborilov@gmail.com> * update flag description Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Pavel <aborilov@gmail.com> * update dashboard docs Signed-off-by: Pavel Aborilov <aborilov@gmail.com> --------- Signed-off-by: Pavel Aborilov <aborilov@gmail.com> Signed-off-by: Pavel <aborilov@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Previously, gzip compression was disabled and not configurable, which made it impossible to work with gzipped Redis cache. This commit adds support for gzip compression to the ArgoCD admin dashboard.
Fixes: #13055
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.