Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua scripts need to be precompiled only on setting changes #1388

Open
jessesuen opened this issue Apr 5, 2019 · 1 comment
Open

Lua scripts need to be precompiled only on setting changes #1388

jessesuen opened this issue Apr 5, 2019 · 1 comment
Labels
component:core Syncing, diffing, cluster state cache enhancement New feature or request type:scalability Issues related to scalability and performance related issues

Comments

@jessesuen
Copy link
Member

Currently we compile the lua scripts on-demand when we perform health assessments. This should be compiled once, every time the settings are modified. Not on every resource assessment.
@jessesuen jessesuen added this to the v1.1 milestone Apr 5, 2019
@alexec alexec added the enhancement New feature or request label Apr 8, 2019
@alexec alexec modified the milestones: v1.1, v1.3 Apr 17, 2019
@alexec alexec added the other label Jun 14, 2019
@alexec alexec removed this from the v1.3 milestone Jun 14, 2019
@stale
Copy link

stale bot commented Aug 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2019
@stale stale bot closed this as completed Aug 20, 2019
@alexmt alexmt removed the wontfix This will not be worked on label Aug 20, 2019
@alexmt alexmt reopened this Aug 20, 2019
@alexec alexec added the backlog label Aug 21, 2019
@alexec alexec removed the other label Oct 10, 2019
@alexmt alexmt removed the backlog label May 13, 2020
@jannfis jannfis added component:core Syncing, diffing, cluster state cache type:scalability Issues related to scalability and performance related issues labels May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:core Syncing, diffing, cluster state cache enhancement New feature or request type:scalability Issues related to scalability and performance related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexmt @alexec @jannfis @jessesuen