Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreDifferences and RespectIgnoreDifferences=true does allow ignoring differences in selected array elements #17694

Open
3 tasks done
alexmt opened this issue Apr 2, 2024 · 5 comments
Labels
bug Something isn't working component:core Syncing, diffing, cluster state cache version:EOL Latest confirmed affected version has reached EOL

Comments

@alexmt
Copy link
Collaborator

alexmt commented Apr 2, 2024

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Once #17693 is merged Argo CD will be able to "ignore" arrays. However it is still not possible to ignore individual array elements. In order to fix it Argo CD would need to use strategic merge patch (using built-in k8s schema and dynamic CRD schema)

To Reproduce

Unit tests from #14602 are reproducing behavior.

Expected behavior

It should be possible to ignore different individual array elements.

Version

v2.10.4
@alexmt
Copy link
Collaborator Author

alexmt commented Apr 2, 2024

Related to #9678

@alexmt
Copy link
Collaborator Author

alexmt commented Apr 2, 2024

If someone attempts to fix it before me. We need to use strategic merge patch here: https://github.com/argoproj/argo-cd/pull/17693/files#diff-627c32a4f31d0f97e6ddc1f19ab3add7fb7791e0d1b0503d78c6c049e8cb4865R438

@jgwest jgwest added the component:core Syncing, diffing, cluster state cache label Apr 2, 2024
@saumeya
Copy link
Contributor

saumeya commented Apr 3, 2024

Yes @alexmt I was attempting to fix it using strategic merge patch, it works well but only supports native k8s resources. Do you have any idea how it could work for custom resources?

@saumeya
Copy link
Contributor

saumeya commented Apr 25, 2024

This issue is partially fixed by PR - #17693 (comment) , fix is only needed for custom resources now.

@andrii-korotkov-verkada
Copy link
Contributor

ArgoCD versions 2.10 and below have reached EOL. Can you upgrade and tell us if the issue is still present, please?

@andrii-korotkov-verkada andrii-korotkov-verkada added the version:EOL Latest confirmed affected version has reached EOL label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:core Syncing, diffing, cluster state cache version:EOL Latest confirmed affected version has reached EOL
Projects
None yet
Development

No branches or pull requests

4 participants