app sync --local submits manifests without namespace in the tracking-id

[lauren-hinge]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

 

Describe the bug

As of #17360, we have better support for Apps in Any Namespaces from the CLI, but even with that, there is still an issue with app sync's --local.

With --local, the sync produces a SharedResourceWarning, reporting that the app's resources are shared between <app-name> and <app-namespace>/<app-name>. This is because they get synced into not having the app namespace in their tracking IDs.

Replicating it in the code, the manifests generated by GenerateManifests (here) are not returned with namespaced tracking id's (the request does not take an appNs).

 

To Reproduce

• app in a non-argocd namespace
• local chart it is pointing to
• argocd app sync --local <path to local chart>
• see a SharedResourceWarning, produced by your local sync having sent manifests without the app namespace in the tracking annotation

 

Expected behavior

argocd app sync --local sends manifests with namespaced tracking id's, so that it does not produce a SharedResourceWarning on apps in non-argocd namespaces

 

Version

argocd: v2.11.0-rc2+24ef777
  BuildDate: 2024-04-15T20:05:04Z
  GitCommit: 24ef7775e79a6ec20b441544aacf8d9d727a676f
  GitTreeState: clean
  GoVersion: go1.21.9
  Compiler: gc
  Platform: darwin/arm64
argocd-server: v2.10.6+d504d2b
  BuildDate: 2024-04-05T00:27:47Z
  GitCommit: d504d2b1d92f0cf831a124a5fd1a96ee29fa7679
  GitTreeState: clean
  GoVersion: go1.21.3
  Compiler: gc
  Platform: linux/amd64
  Kustomize Version: v5.2.1 2023-10-19T20:13:51Z
  Helm Version: v3.14.3+gf03cc04
  Kubectl Version: v0.26.11
  Jsonnet Version: v0.20.0