Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add livenessProbe for argocd-application-controller #18338

Open
acelinkio opened this issue May 21, 2024 · 1 comment
Open

Add livenessProbe for argocd-application-controller #18338

acelinkio opened this issue May 21, 2024 · 1 comment

Comments

@acelinkio
Copy link

Summary

Add/Identify livenessProbe for argocd-application-controller

Motivation

argocd-application-controller became unresponsive and needed to be restarted in #18334. argo-cd should self heal where possible and without manual intervention.

Proposal

I am unsure what would be the best avenue for adding a livenessProbe. We could copy the existing readinessprobe that uses the metrics endpoint on port 8082--but that does not seem like a viable long term solution.

I am a bit tentative on forcing a livenessProbe without consulting the community. The helm chart does not accept any controller livenessProbe inputs, so I am concerned adding one may cause more problems.

My biggest fear is that the application-controller is restarted mid proccess and becomes disruption even on the resources it manages. If there is any documentation on how the application-controller actually manages applications, that would be greatly appreciated and also help with identifying a valid probe.

@acelinkio acelinkio added the enhancement New feature or request label May 21, 2024
@acelinkio
Copy link
Author

Will gladly open a pull request to the helm chart once a livenessProbe is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants