Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydrator: short-circuit hydration on hydrator.metadata drySha #19592

Open
crenshaw-dev opened this issue Aug 19, 2024 · 2 comments
Open

hydrator: short-circuit hydration on hydrator.metadata drySha #19592

crenshaw-dev opened this issue Aug 19, 2024 · 2 comments
Labels
component:hydrator enhancement New feature or request hydrator Issues related to the manifest hydrator.

Comments

@crenshaw-dev
Copy link
Member

Today the hydrator will re-run hydration even if the target dry SHA has already been hydrated.

We should add logic to commit.go to read hydrator.metadata in the target branch (if present). If the dry SHA in hydrator.metadata matches the one being hydrated, we should log, quit early, and return a success code.
@crenshaw-dev crenshaw-dev added enhancement New feature or request hydrator Issues related to the manifest hydrator. component:hydrator labels Aug 19, 2024
@jcy0308
Copy link

jcy0308 commented Aug 23, 2024 •
edited
Loading

@crenshaw-dev Can I work on this issue?? I'll try my best!

@crenshaw-dev
Copy link
Member Author

@jcy0308 go for it!

@jcy0308 jcy0308 mentioned this issue Sep 12, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:hydrator enhancement New feature or request hydrator Issues related to the manifest hydrator.
Projects
Argo CD Manifest Hydrator
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crenshaw-dev @jcy0308