Short Commit SHA produces an error after first refresh #19820
Labels
bug
Something isn't working
component:git
Interaction with GitHub, Gitlab etc
component:sync
version:2.12
Latest confirmed affected version is 2.12
Checklist:
argocd version
.Describe the bug
When short commit SHA is used the app initially produces the error
The error however disappears after the next refresh actions
To Reproduce
create an application and use short SHA as targetRevision
change the target revision to another short SHA , and refresh the app, observe the error
refresh the app again and the error is gone the sync message points to correct revision and everything is synced
Expected behavior
No error should be shown
Screenshots
Version
argocd: v2.6.7+5bcd846.dirty BuildDate: 2023-03-23T17:23:10Z GitCommit: 5bcd846fa16e4b19d8f477de7da50ec0aef320e5 GitTreeState: dirty GoVersion: go1.20.2 Compiler: gc Platform: darwin/arm64 WARN[0000] Failed to invoke grpc call. Use flag --grpc-web in grpc calls. To avoid this warning message, use flag --grpc-web. argocd-server: v2.12.0+ec30a48 BuildDate: 2024-08-05T13:25:54Z GitCommit: ec30a48bce7a60046836e481cd2160e28c59231d GitTreeState: clean GoVersion: go1.22.4 Compiler: gc Platform: linux/amd64 Kustomize Version: v5.4.2 2024-05-22T15:19:38Z Helm Version: v3.15.2+g1a500d5 Kubectl Version: v0.29.6 Jsonnet Version: v0.20.0
Logs
I think the issue is in client.go
file where it is tested only by
IsCommitSHA
function, but instead bothIsCommitSHA
andIsTruncatedCommitSHA
? WDYT?git diff comand works with shortSHA as well so I do not see any blocker to do it
The text was updated successfully, but these errors were encountered: