Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with implicit convention in helm.valuefiles field of GetAppDetails api #3494

Open
sjkim2322 opened this issue Apr 27, 2020 · 0 comments
Labels
bug Something isn't working component:config-management Tools specific issues (helm, kustomize etc)

Comments

@sjkim2322
Copy link

https://{host}/api/v1/repositories/{source.repoURL}/appdetails

The above api (in the case of helm) gets the necessary detail information from the helm chart of the repository.
The response of this api is also provided as an option to select the helm value file when creating an argo application in web ui.

스크린샷 2020-04-27 오후 5 59 31

In addition to values.yaml, custom-defined value files can be added to helm.valueFiles (e.g values-production.yaml).

if strings.Contains(fName, "values") && (filepath.Ext(fName) == ".yaml" || filepath.Ext(fName) == ".yml") {

According to the source link above, the files corresponding to the value file are filtered based on the path of the chart received from the repository (whether it contains "values" string or .yaml file or yml file).

Not all files under the chart path can be included in helm.valuesFiles, so filtering is required.

However, the convention "values" string must be included in the name of the value file is not visible in the helm documentation.

this seems like an implicit and habitual rule to those familiar with helm.

The helm itself doesn't actually need restrictions. Since the user directly specifies the file name
(helm install chart -f prod.yaml)

Due to the above issue, a file in the form of "prod.yaml" on the chart is not displayed on the ui.

Therefore, I hope that a note about this implicit restriction is added to the argo document.

@jannfis jannfis added bug Something isn't working component:config-management Tools specific issues (helm, kustomize etc) labels May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:config-management Tools specific issues (helm, kustomize etc)
Projects
None yet
Development

No branches or pull requests

2 participants