Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --post-renderer flag for helm #3882

Closed
musabmasood opened this issue Jun 30, 2020 · 1 comment
Closed

Support --post-renderer flag for helm #3882

musabmasood opened this issue Jun 30, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@musabmasood
Copy link

Summary

Helm 3 now supports the --post-renderer flag which is great for last mile modifications of a chart without forking it. It would be great if argocd can support this flag for helm applications.

Motivation

Many a times we want to install a helm chart but its missing some customization e.g. adding a sidecar. Usually we can pass the output of helm template to kustomize and then make these changes.

Since helm now supports the --post-renderer flag, it would be great to use it directly in application.yaml manifests.

Proposal

Since argocd already ships with kustomize, may be the helm specification of the application.yaml can add kustomization support:

    ...
    # helm specific config
    helm:
       kustomizeRenderer: <path/to/kustomization.yaml/in/same/repo>
       valueFiles:
       ...
@musabmasood musabmasood added the enhancement New feature or request label Jun 30, 2020
@crenshaw-dev
Copy link
Member

I think this is a duplicate of #3698

@crenshaw-dev crenshaw-dev closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants