Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit sha isn't listed for unknown #5442

Open
3 tasks
jsoref opened this issue Feb 7, 2021 · 2 comments
Open
3 tasks

Commit sha isn't listed for unknown #5442

jsoref opened this issue Feb 7, 2021 · 2 comments
Labels
component:ui User interfaces bugs and enhancements ui-polish

Comments

@jsoref
Copy link
Member

jsoref commented Feb 7, 2021

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a question in argocd slack channel.

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

When the system is healthy, it reports the branch and commit sha. When it's in an unknown state, it seems to report the desired branch.

The problem is, I can't tell if it's failing w/ my "fixed" commit, or still failing on the previous commit. I'm assuming that it knows which commit it checked out to try to perform work, even if it didn't like the results.

To Reproduce

A list of the steps required to reproduce the issue. Best of all, give us the URL to a repository that exhibits this issue. See #5441

Expected behavior

Report the commit sha if applicable, or an error message justifying the lack of availability of such information.

Screenshots

image

Version

{
    "Version": "v1.9.0+00f53b5",
    "BuildDate": "2021-01-27T00:04:02Z",
    "GitCommit": "00f53b510d87750492d8446e3303f6ab28258bce",
    "GitTreeState": "clean",
    "GoVersion": "go1.14.12",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KsonnetVersion": "v0.13.1",
    "KustomizeVersion": "v3.8.1 2020-07-16T00:58:46Z",
    "HelmVersion": "v3.4.1+gc4e7485",
    "JsonnetVersion": "v0.17.0"
}

Logs

Paste any relevant application logs here.
@jsoref jsoref added the bug Something isn't working label Feb 7, 2021
@jsoref
Copy link
Member Author

jsoref commented Feb 7, 2021

One point of clarity, this was actually a templated application. It was never healthy, but there was definitely a commit sha that was used to try to instantiate the application. It just didn't actually work. It's still important to know which sha that was.

I made a commit which would cause the application not to be created, and I needed to know if that was seen.

@rbreeze rbreeze added component:ui User interfaces bugs and enhancements ui-polish and removed bug Something isn't working labels Feb 8, 2021
@Eslam-mohammed-anwar
Copy link

Yes we experience the same issue here ,as the argo notification failed to push github statue with error

level=error msg="Failed to notify recipient {github ""} defined in resource default/xxxxx-qa: POST https://api.github.com/repos/xxxxx/xxxxx/statuses/%3Cno%20value%3E: 422 No commit found for SHA: []" resource=default/xxxxxxx-qa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements ui-polish
Projects
None yet
Development

No branches or pull requests

3 participants