Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints diff confused by ports sorting #6300

Closed
zebraincognito opened this issue May 21, 2021 · 8 comments · Fixed by argoproj/gitops-engine#347
Closed

Endpoints diff confused by ports sorting #6300

zebraincognito opened this issue May 21, 2021 · 8 comments · Fixed by argoproj/gitops-engine#347
Assignees
Labels
bug Something isn't working regression Bug is a regression, should be handled with high priority
Milestone

Comments

@zebraincognito
Copy link

Describe the bug

Hello, I believe the bug is similar to this one #1816 (comment)
but happens with endpoints with multiple ports defined.
Endpoints that have multiple ports definitions in yamls are always OutOfSync due to difference between desired manifest and applied one with reordered ports entries:
argocd-diff

To Reproduce

Sync Endpoints manifest with multiple defined ports.

Expected behavior

If reordering happens it shouldn't be considered as manifests difference.
Endpoints should be in sync.

Version

Argo CD
v2.0.0+f5119c0

@zebraincognito zebraincognito added the bug Something isn't working label May 21, 2021
@zebraincognito zebraincognito changed the title Endpoints diff confused be ports sorting Endpoints diff confused by ports sorting May 21, 2021
@jessesuen jessesuen added this to the v2.1 milestone May 24, 2021
@jessesuen
Copy link
Member

We currently special case Endpoint diffing by sorting upper-level array but not currently ports. Should sort ports as well.

@wtam2018
Copy link
Contributor

Please assign to me.

@alexmt
Copy link
Collaborator

alexmt commented Jun 8, 2021

Discovered that issue is fixed by argoproj/gitops-engine#258 . Fix will be available in 2.1

@alexmt alexmt closed this as completed Jun 8, 2021
@zebraincognito
Copy link
Author

The issue still persists in 2.1, could you take a look?

@alexmt alexmt reopened this Sep 2, 2021
@alexmt alexmt modified the milestones: v2.1, v2.2 Sep 2, 2021
@alexmt alexmt added the regression Bug is a regression, should be handled with high priority label Sep 2, 2021
@doyelese
Copy link

doyelese commented Sep 2, 2021

Encountering this issue also with subset addresses:

Screen Shot 2021-09-02 at 1 21 54 PM

@alexmt
Copy link
Collaborator

alexmt commented Jan 26, 2022

PR argoproj/gitops-engine#347 fixed ports issue but addresses issue is still there. Working on second PR to fix it as well

@alexmt
Copy link
Collaborator

alexmt commented Jan 26, 2022

Created separate ticket for endpoint addresses #8287

@MPV
Copy link
Contributor

MPV commented Mar 22, 2022

@alexmt Looks lik #8288 only bumped the gitops engine to 0.5.x but argoproj/gitops-engine#347 isn't included until 0.6.x. Time to bump it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Bug is a regression, should be handled with high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants