-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoints diff confused by ports sorting #6300
Comments
We currently special case Endpoint diffing by sorting upper-level array but not currently ports. Should sort ports as well. |
Please assign to me. |
Discovered that issue is fixed by argoproj/gitops-engine#258 . Fix will be available in 2.1 |
The issue still persists in 2.1, could you take a look? |
PR argoproj/gitops-engine#347 fixed ports issue but addresses issue is still there. Working on second PR to fix it as well |
Created separate ticket for endpoint addresses #8287 |
@alexmt Looks lik #8288 only bumped the gitops engine to |
Describe the bug
Hello, I believe the bug is similar to this one #1816 (comment)
but happens with endpoints with multiple ports defined.
Endpoints that have multiple ports definitions in yamls are always OutOfSync due to difference between desired manifest and applied one with reordered ports entries:
To Reproduce
Sync Endpoints manifest with multiple defined ports.
Expected behavior
If reordering happens it shouldn't be considered as manifests difference.
Endpoints should be in sync.
Version
Argo CD
v2.0.0+f5119c0
The text was updated successfully, but these errors were encountered: