Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain rightmost git generator path parameter behavior #9799

Conversation

reilly3000
Copy link
Contributor

There was some confusion regarding how the AppSet Git Generator provides path parameters. This clarifies docs to explain that the final directory in a path is not accessible via {{path[n]}} but is always {{path.basename}}.

@crenshaw-dev crenshaw-dev changed the title Docs: explain rightmost git generator path parameter behavior docs: explain rightmost git generator path parameter behavior Jun 27, 2022
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @reilly3000!

@crenshaw-dev crenshaw-dev added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Jun 27, 2022
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 27, 2022 20:56
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #9799 (5ad9d65) into master (a041bf8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9799   +/-   ##
=======================================
  Coverage   45.79%   45.79%           
=======================================
  Files         227      227           
  Lines       26920    26920           
=======================================
  Hits        12327    12327           
  Misses      12911    12911           
  Partials     1682     1682           
Impacted Files Coverage Δ
util/settings/settings.go 48.16% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a041bf8...5ad9d65. Read the comment docs.

@crenshaw-dev crenshaw-dev merged commit 1434e89 into argoproj:master Jun 27, 2022
crenshaw-dev pushed a commit that referenced this pull request Jun 29, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Member

Cherry-picked onto release-2.4 for 2.4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants