chore: wrap errors with message (#10592)

[apoorvam1]

Signed-off-by: Apoorva Mahabaleshwara apoorvambhat@gmail.com
Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Base: 45.64% // Head: 45.65% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (86d1254) compared to base (8a71b8a).
Patch coverage: 15.62% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10986      +/-   ##
==========================================
+ Coverage   45.64%   45.65%   +0.01%     
==========================================
  Files         237      237              
  Lines       28729    28738       +9     
==========================================
+ Hits        13114    13121       +7     
- Misses      13810    13811       +1     
- Partials     1805     1806       +1     

Impacted Files	Coverage Δ
cmd/argocd/commands/root.go	5.88% <0.00%> (ø)
controller/appcontroller.go	51.78% <0.00%> (ø)
controller/state.go	72.58% <0.00%> (ø)
cmd/argocd/commands/version.go	38.14% <20.00%> (+4.05%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[crenshaw-dev]

Thanks @apoorvam1! Added some suggestions. Usually it's best to have the error message describe the action taken immediately before the error.

[crenshaw-dev]

Suggested change

	return fmt.Errorf("error while finalizing the project deletion: %w", err)
	return fmt.Errorf("error listing applications: %w", err)

[crenshaw-dev]

Suggested change

	return fmt.Errorf("error while removing cascade finalizer: %w", err)
	return fmt.Errorf("error getting project: %w", err)

[crenshaw-dev]

Suggested change

	return fmt.Errorf("error while setting the operation state: %w", err)
	return fmt.Errorf("error marshaling json: %w", err)

[crenshaw-dev]

Suggested change

	return fmt.Errorf("error while setting the operation state: %w", err)
	return fmt.Errorf("error merging operation state patch: %w", err)

[crenshaw-dev]

Suggested change

	return fmt.Errorf("error while setting the operation state: %w", err)
	return fmt.Errorf("error patching application with operation state: %w", err)

[crenshaw-dev]

Suggested change

	return fmt.Errorf("error while saving the revision history: %w", err)
	return fmt.Errorf("error marshaling revision history patch: %w", err)

[crenshaw-dev]

lgtm, thanks @apoorvam1!