chore: fix e2e #11005
Merged
chore: fix e2e #11005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportBase: 45.64% // Head: 45.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11005 +/- ##
==========================================
+ Coverage 45.64% 45.65% +0.01%
==========================================
Files 237 237
Lines 28729 28738 +9
==========================================
+ Hits 13114 13121 +7
- Misses 13810 13811 +1
- Partials 1805 1806 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8 tasks
crenshaw-dev
added
cherry-pick/2.2
nsinghal12
pushed a commit
to nsinghal12/argo-cd
that referenced
this pull request
Oct 20, 2022
* chore: fix e2e Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more config Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * global Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Niti Singhal <gupta.sweet.niti@gmail.com>
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Oct 21, 2022
* chore: fix e2e Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more config Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * global Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
crenshaw-dev
added a commit
that referenced
this pull request
Oct 21, 2022
* chore: fix e2e Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more config Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * global Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Oct 21, 2022
* chore: fix e2e Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more config Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * global Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Oct 21, 2022
* chore: fix e2e Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more config Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * global Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Oct 21, 2022
* chore: fix e2e Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more config Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * global Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Oct 21, 2022
* chore: wrap errors with message (#10592) (#10986) * issue-10592 Wrap errors with message Signed-off-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> * issue-10592 remove unwanted error wrappers Signed-off-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> * chore: fix error wrapper messages Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> Signed-off-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> Co-authored-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: emirot <emirot.nolan@gmail.com> * test: simplify test Signed-off-by: emirot <nolan.emirot@workday.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * trigger ci Signed-off-by: emirot <emirot.nolan@gmail.com> * feat: sort resource list by created_at, add message to AnalysisRun and replicas to ReplicaSet (#10613) * Misc UI Improvements: sort by created at in resource list view, add message to AnalysisRun and replicas to Replicaset Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Address PR comments Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * No underscore needed in created_at. Add space between icon and message in health details for non-controlled resources Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Guard section Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software> Signed-off-by: emirot <emirot.nolan@gmail.com> * chore: fix e2e (#11005) * chore: fix e2e Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more config Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * global Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> Signed-off-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> Signed-off-by: emirot <nolan.emirot@workday.com> Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: apoorvam1 <apoorvambhat@gmail.com> Co-authored-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Co-authored-by: emirot <nolan.emirot@workday.com> Co-authored-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
emirot
added a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
* chore: wrap errors with message (argoproj#10592) (argoproj#10986) * issue-10592 Wrap errors with message Signed-off-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> * issue-10592 remove unwanted error wrappers Signed-off-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> * chore: fix error wrapper messages Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> Signed-off-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> Co-authored-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: emirot <emirot.nolan@gmail.com> * test: simplify test Signed-off-by: emirot <nolan.emirot@workday.com> Signed-off-by: emirot <emirot.nolan@gmail.com> * trigger ci Signed-off-by: emirot <emirot.nolan@gmail.com> * feat: sort resource list by created_at, add message to AnalysisRun and replicas to ReplicaSet (argoproj#10613) * Misc UI Improvements: sort by created at in resource list view, add message to AnalysisRun and replicas to Replicaset Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Address PR comments Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * No underscore needed in created_at. Add space between icon and message in health details for non-controlled resources Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> * Guard section Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software> Signed-off-by: emirot <emirot.nolan@gmail.com> * chore: fix e2e (argoproj#11005) * chore: fix e2e Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * more config Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * global Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com> Signed-off-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Signed-off-by: Apoorva Mahabaleshwara <apoorvambhat@gmail.com> Signed-off-by: emirot <emirot.nolan@gmail.com> Signed-off-by: emirot <nolan.emirot@workday.com> Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: apoorvam1 <apoorvambhat@gmail.com> Co-authored-by: Apoorva Mahabaleshwara <apoorvamahabaleshwara@Apoorvas-MBP.attlocal.net> Co-authored-by: emirot <nolan.emirot@workday.com> Co-authored-by: Alex Eftimie <alex.eftimie@getyourguide.com> Co-authored-by: Remington Breeze <remington@breeze.software> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's broken because of this. https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#upgrade-to-the-latest-git-version