-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support context switch for argocd-util #7538
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7538 +/- ##
=======================================
Coverage 45.67% 45.68%
=======================================
Files 353 353
Lines 46947 46952 +5
=======================================
+ Hits 21445 21451 +6
Misses 22762 22762
+ Partials 2740 2739 -1 ☔ View full report in Codecov by Sentry. |
|
@wtam2018 Thank you for the review. No, there is no other than this one line change. In my understanding, basically |
I also noticed from one failure in CI that the newly added |
Signed-off-by: Atsushi Neki <nekiaiken@gmail.com>
c68b94a
to
663962a
Compare
This simple and realy usefull change still not merged to the master branch, is there any reason for that? my only workaround without this change is use --config and make different config files for each argocd context |
Any update on this PR ? |
@nekia I think this stalled primarily because there is a decent workaround with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets just fix conflicts.
Signed-off-by: Dan Garfield <dan@codefresh.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@nekia could you please do docsgen again ? |
Signed-off-by: pasha-codefresh <pavel@codefresh.io>
It looks like we still have one of the checks failing before we can merge. Anyone know how to fix it? |
Signed-off-by: Atsushi Neki nekiaiken@gmail.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Fixes #5912