-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: adding kube-context flag #8849
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8849 +/- ##
==========================================
+ Coverage 45.00% 45.02% +0.02%
==========================================
Files 212 212
Lines 25272 25284 +12
==========================================
+ Hits 11373 11385 +12
- Misses 12292 12295 +3
+ Partials 1607 1604 -3
Continue to review full report at Codecov.
|
Good job on your first PR @elad-codefresh ! |
enhancement proposal: |
…if wanted. #8829 Signed-off-by: elad-codefresh <elad.laor@codefresh.io>
Signed-off-by: elad-codefresh <elad.laor@codefresh.io>
Signed-off-by: elad-codefresh <elad.laor@codefresh.io>
Thank you, just one comment, Why are you doing clientOpts.KubeOverrides.CurrentContext and not clientOpts.Context? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thank you!
* feature: adding support for kube-context flag to override kubeconfig if wanted. argoproj#8829 Signed-off-by: elad-codefresh <elad.laor@codefresh.io> * feat: fixed lint Signed-off-by: elad-codefresh <elad.laor@codefresh.io> * feat: codegen Signed-off-by: elad-codefresh <elad.laor@codefresh.io> Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
* feature: adding support for kube-context flag to override kubeconfig if wanted. argoproj#8829 Signed-off-by: elad-codefresh <elad.laor@codefresh.io> * feat: fixed lint Signed-off-by: elad-codefresh <elad.laor@codefresh.io> * feat: codegen Signed-off-by: elad-codefresh <elad.laor@codefresh.io> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Should this work in 2.3.4? The documented --kube-context string doesn't seem to work for me. Thanks |
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: