Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argo-ci and pr check #34

Closed
magaldima opened this issue Jun 21, 2018 · 5 comments
Closed

Add argo-ci and pr check #34

magaldima opened this issue Jun 21, 2018 · 5 comments
Assignees
@shrinandj

Comments

@magaldima
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Since this project is now under the Argo Project, we should follow suite with the other projects and add an .argo-ci/ci.yaml file and setup the appropriate build/test checks.

Describe the solution you'd like
Create the CI process for Argo-Events.

Describe alternatives you've considered
I have a working .travis.yml file in the repo and was previously using Travis-CI test/builds to verify PR checks. I would need access to the Travis CI for Argo.
@magaldima magaldima added question help wanted Extra attention is needed labels Jun 21, 2018
@magaldima
Copy link
Contributor Author

@edlee2121 @shrinandj Can you guys tackle this issue? Right now, we just need it to run the project tests.

@shrinandj
Copy link
Contributor

Sure. I'll do this.

@magaldima magaldima removed the help wanted Extra attention is needed label Jun 27, 2018
@shrinandj
Copy link
Contributor

I have access to the Kubernetes cluster where Argo's current builds happen.

Currently creating the workflow for building argo-events. Once I have the workflow executing correctly, I'll create the appropriate webhooks in Github to send the request to K8s cluster for building everytime a PR is created.

@shrinandj
Copy link
Contributor

I created a workflow for running the CI for argo-events. However, I'm running into a problem where the workflow does not complete even though the pod execution has completed. Filed an issue on the main argo repo for it.

argoproj/argo-workflows#898

shrinandj added a commit to shrinandj/argo-events that referenced this issue Jul 5, 2018
@shrinandj
Add workflow for CI.
9c99327 
This commit creates the workflow that will be run on every PR for argo-events.

Testing Done:

1. Ran workflow independently on a cluster. It succeeded modulo appropriate RBAC role
(See argoproj/argo-workflows#898 for details).

Refs argoproj#34.
@shrinandj shrinandj mentioned this issue Jul 5, 2018
Merged
magaldima pushed a commit that referenced this issue Jul 10, 2018
@shrinandj @magaldima
Add workflow for CI. (#42)
8fde9ce 
This commit creates the workflow that will be run on every PR for argo-events.

Testing Done:

1. Ran workflow independently on a cluster. It succeeded modulo appropriate RBAC role
(See argoproj/argo-workflows#898 for details).

Refs #34.
@shrinandj
Copy link
Contributor

CI for pull-requests has been setup.

juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
@shrinandj @magaldima
Add workflow for CI. (argoproj#42)
f104104 
This commit creates the workflow that will be run on every PR for argo-events.

Testing Done:

1. Ran workflow independently on a cluster. It succeeded modulo appropriate RBAC role
(See argoproj/argo-workflows#898 for details).

Refs argoproj#34.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shrinandj shrinandj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shrinandj @magaldima