Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url_test hangs when behind proxy #70

Closed
magaldima opened this issue Jul 26, 2018 · 1 comment
Closed

url_test hangs when behind proxy #70

magaldima opened this issue Jul 26, 2018 · 1 comment
Assignees
@shrinandj
Labels
bug Something isn't working

Comments

@magaldima
Copy link
Contributor

Describe the bug
Running make test hangs on the store package and specifically on the url_test.go TestURLReader test.

To Reproduce
Steps to reproduce the behavior:

  1. run make test

Expected behavior
The test should pass and the test should not be dependent on an internet connection or the outside world.

We should use the httptest package to run a localhost server while running this test.
@magaldima magaldima added the bug Something isn't working label Jul 26, 2018
@shrinandj
Copy link
Contributor

I'll take a look. Another option would be to mock the call to client.Get. Will check if there's a way to do that.

shrinandj added a commit to shrinandj/argo-events that referenced this issue Jul 27, 2018
@shrinandj
Serve and read from local server for url test.
0d5f762 
Instead of reading a Github url, this commit starts and local http server and makes
the URLReader read from that server.

Closes argoproj#70.
@shrinandj shrinandj mentioned this issue Jul 27, 2018
Merged
magaldima pushed a commit that referenced this issue Jul 28, 2018
@shrinandj @magaldima
Serve and read from local server for url test. (#77)
a1138ed 
Instead of reading a Github url, this commit starts and local http server and makes
the URLReader read from that server.

Closes #70.
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
@shrinandj @magaldima
Serve and read from local server for url test. (argoproj#77)
ff688f0 
Instead of reading a Github url, this commit starts and local http server and makes
the URLReader read from that server.

Closes argoproj#70.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shrinandj shrinandj

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shrinandj @magaldima