Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate eventSourceName/eventName validation in Sensor #971

Closed
whynowy opened this issue Nov 24, 2020 · 1 comment · Fixed by #972
Closed

Duplicate eventSourceName/eventName validation in Sensor #971

whynowy opened this issue Nov 24, 2020 · 1 comment · Fixed by #972
Labels
enhancement New feature or request

Comments

@whynowy
Copy link
Member

whynowy commented Nov 24, 2020

Is your feature request related to a problem? Please describe.
Same eventSourceName + eventName are not allowed to define multiple times in one Sensor object, this should be validated in sensor-controller.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@whynowy whynowy added the enhancement New feature or request label Nov 24, 2020
whynowy added a commit to whynowy/argo-events that referenced this issue Nov 30, 2020
Signed-off-by: Derek Wang <whynowy@gmail.com>
whynowy added a commit that referenced this issue Dec 3, 2020
* feat: Validate dependencies duplication. Closes #971

Signed-off-by: Derek Wang <whynowy@gmail.com>

* fix test case

Signed-off-by: Derek Wang <whynowy@gmail.com>

Co-authored-by: Vaibhav <vaibhav.page@gmail.com>
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
…j#972)

* feat: Validate dependencies duplication. Closes argoproj#971

Signed-off-by: Derek Wang <whynowy@gmail.com>

* fix test case

Signed-off-by: Derek Wang <whynowy@gmail.com>

Co-authored-by: Vaibhav <vaibhav.page@gmail.com>
@jomach
Copy link
Contributor

jomach commented Apr 12, 2022

this is very useful:

    - name: kafka-message
      eventSourceName: kafka
      eventName: datahub-notify-event-source
      # https://github.com/argoproj/argo-events/blob/master/examples/sensors/filter-with-expressions.yaml
      filters:
        expr:
          - expr: component == "data-service" && eventType == "commit-dataset"
            fields:
              - name: component
                path: component
              - name: eventType
                path: eventType
    - name: dataset_id
      eventSourceName: kafka
      eventName: datahub-notify-event-source
      transform:
        jq: ".datasetId"
    - name: tenant
      eventSourceName: kafka
      eventName: datahub-notify-event-source
      transform:
        jq: "tenant"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants