Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource gateway #185

Merged
merged 9 commits into from
Feb 27, 2019
Merged

Fix resource gateway #185

merged 9 commits into from
Feb 27, 2019

Conversation

VaibhavPage
Copy link
Contributor

@VaibhavPage VaibhavPage added the bug Something isn't working label Feb 26, 2019
magaldima
magaldima previously approved these changes Feb 27, 2019
Copy link
Contributor

@magaldima magaldima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version inconsistencies, but otherwise looks good to me!

@@ -8,15 +8,15 @@ spec:
deploySpec:
containers:
- name: "sensor"
image: "argoproj/sensor"
image: "argoproj/sensor:v0.7.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be v0.8 to be in sync with makefile?

@magaldima magaldima merged commit 3eee3c9 into master Feb 27, 2019
@magaldima magaldima deleted the fix-resource-gateway branch March 1, 2019 13:43
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
* chore(): adding gateway examples

* fix(): updating resource gateway. renew watch.

* fix(): adding informer factory to watch updates

* fix(): adding informer factory to watch updates

* fix(): renewing watch in resource gateway

* fix(): update example

* fix(): update makefile

* fix(): fix calendar gateway bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants