-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support regexp path #191
Support regexp path #191
Conversation
9f800b3
to
12cf203
Compare
I found the following error on the gateway-client side when I was testing this function and there's no output on the gateway side. I'm investigating it...
|
looks like the |
@VaibhavPage Looks like my the versions of gateway-client and hdfs-gateway are inconsistent. I confirmed the problem above doesn't happen after I updated the gateway-client image. Could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!!! Nice to see file watcher gateway benefitting from common path regex functionality.
I think supporting regexp paths is very useful when you want to monitor multiple files created in a specific directory.