Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revision History Limit for sensor. Closes #1786 #2244

Merged
merged 2 commits into from
Oct 13, 2022
Merged

feat: Revision History Limit for sensor. Closes #1786 #2244

merged 2 commits into from
Oct 13, 2022

Conversation

AalokAhluwalia
Copy link
Contributor

@AalokAhluwalia AalokAhluwalia commented Oct 12, 2022

Closes: #1786

Checklist:

@AalokAhluwalia
Copy link
Contributor Author

Addresses: #1786

@AalokAhluwalia AalokAhluwalia marked this pull request as ready for review October 12, 2022 19:44
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whynowy whynowy changed the title Issue-1786: Revision History Limit for sensor feat: Revision History Limit for sensor. Closes #1786 Oct 13, 2022
@whynowy whynowy merged commit 00e5fd0 into argoproj:master Oct 13, 2022
whynowy pushed a commit that referenced this pull request Dec 12, 2022
Signed-off-by: Derek Wang <whynowy@gmail.com>
@tooptoop4
Copy link
Contributor

can eventsource be overwritten?

@whynowy
Copy link
Member

whynowy commented Dec 14, 2022

can eventsource be overwritten?

With a similar PR:)

bilalba pushed a commit to intuit-data-os/argo-events that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overwrite revisionHistoryLimit for Sensor Deployment
3 participants