feat: Unified gateway deployment image. Closes #639 #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynowy
commented
May 8, 2020
VaibhavPage
reviewed
May 8, 2020
|
@VaibhavPage - Thanks! Before I click the |
|
Can we make the yaml file changes part of another PR just before next release? So you can merge the code changes. |
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
…#648) * feat: Unified gateway deployment image. Closes argoproj#639 * make deployment logic change * update manifests * Dockerfile change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified image for all the gateways, start the service with an argument to specify the type.
Closes #639
This commit also updated the Dockerfiles for gateway-controller, sensor-controller and gateway-client to use
scratch, this reduces the image size by 70-80% and brings more secure.