fix(argo-applicationset): Fix leader election rbac #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>
Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>
|
/assign @jgwest The resulting RBAC is different from the one in https://github.com/argoproj-labs/applicationset/blob/master/manifests/install.yaml |
jgwest
suggested changes
Apr 14, 2021
|
I will try again with a fresh install with kind and I will get back to you.
…On Wed, Apr 14, 2021, 14:50 Jonathan West ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In charts/argo-applicationset/ci/default-values.yaml
<#674 (comment)>:
> + # lines, adjust them as necessary, and remove the curly braces after 'resources:'.
+ # limits:
+ # cpu: 100m
+ # memory: 128Mi
+ # requests:
+ # cpu: 100m
+ # memory: 128Mi
+
+nodeSelector: {}
+
+tolerations: []
+
+affinity: {}
+
+# An empty argocd installation doesn't have any of those volumes
+mountSSHKnownHostsVolume: false
An empty argocd installation doesn't have any of those volumes
Is this true? The applicationset 'install with argo yaml'
<https://github.com/argoproj-labs/applicationset/blob/8100e6bf539029a39ebeb9d8094fc3885afa36d7/manifests/install-with-argo-cd.yaml#L3876>
and the Argo CD version install yaml
<https://raw.githubusercontent.com/argoproj/argo-cd/stable/manifests/install.yaml>
definitely contain these values.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#674 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEZHCDPAZUM7VSAVDYTA7LTIWFQPANCNFSM424257CQ>
.
|
Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>
jgwest
approved these changes
Apr 14, 2021
Sure, that would be great. |
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
* fix(argo-applicationset): Fix leader election rbac * fix(argo-applicationset): Add tests * Use defaults volume mount flags Signed-off-by: Matteo Ruina <matteo.ruina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matteo Ruina matteo.ruina@gmail.comNote on DCO:
ctctoutput at https://gist.github.com/maruina/4834393a87458127209fe66fa83fabebChecklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.