fix: append weighted destination only when weight is mentioned

[divyansh375]

As of now, in canary deployment with weighted experiment, the rollout throws nil pointer exception, when in an experiment step, one template contains weight and the other doesn't. For example:

Hence handling a nil pointer check and also a UT verification for port name .

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[github-actions]

Go Published Test Results

2 097 tests   2 097 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit e09f049.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (723f7a9) 81.79% compared to head (e09f049) 81.87%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2734      +/-   ##
==========================================
+ Coverage   81.79%   81.87%   +0.08%     
==========================================
  Files         135      135              
  Lines       20649    20650       +1     
==========================================
+ Hits        16889    16908      +19     
+ Misses       2885     2869      -16     
+ Partials      875      873       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

E2E Tests Published Test Results

  4 files    4 suites   3h 26m 55s ⏱️
106 tests  95 ✅  6 💤 5 ❌
430 runs  401 ✅ 24 💤 5 ❌

For more details on these failures, see this check.

Results for commit e09f049.

♻️ This comment has been updated with latest results.

[zachaller]

Can we also add a unit test for the nil pointer check?

[divyansh375]

Hi @zachaller thanks for reviewing, let me add that as well

[divyansh375]

Hi @zachaller please could you review this? apologies for taking so long to address your comment, I have made few changes in the existing UT itself because the existing UT "TestRolloutWithExperimentStep" was not covering the desired code.. It was logging error but somehow the UT was passing.

[divyansh375]

@zachaller Hi please could you update on this?

[divyansh375]

@zachaller please let me know if any further change is required before we can merge this

[divyansh375]

@leoluz please could you review?

[divyansh375]

@zachaller please can you review

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
3.7% Duplication

[divyansh375]

@zachaller please can you review

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
15.9% Duplication

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
8.5% Duplication on New Code

See analysis details on SonarCloud