feat: Support instance ids for rollout controller segregation #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthomson25
changed the title
dthomson25
changed the title
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 84.04% 84.14% +0.09%
==========================================
Files 66 66
Lines 6055 6092 +37
==========================================
+ Hits 5089 5126 +37
Misses 689 689
Partials 277 277
Continue to review full report at Codecov.
|
dthomson25
force-pushed
the
instance-id
branch
2 times, most recently
from
36bfadf
to
0946b2b
Compare
dthomson25
force-pushed
the
instance-id
branch
from
0946b2b
to
48e904d
Compare
jessesuen
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #304
Adds a new flag to the controller called
--instance-id. This flag indicates that the controller should only operate on Argo Rollout objects that have that labelargo-rollouts.argoproj.io/controller-instance-idwith the same value passed into the flag. If the flag is not listed, the controller operates on any Argo Rollout object that does not have theargo-rollouts.argoproj.io/controller-instance-idlabel.