fix: e2e test

Signed-off-by: shuangkun <tsk2013uestc@163.com>
argoproj · Feb 27, 2024 · 3b5265c · 3b5265c
1 parent 7a64c72
commit 3b5265c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/test/e2e/fixtures/when.go b/test/e2e/fixtures/when.go
@@ -209,6 +209,11 @@ var (
 			return node.Type == wfv1.NodeTypePod && node.Phase == wfv1.NodeRunning
 		}), "to have running pod"
 	}
+	ToHaveFailedPod Condition = func(wf *wfv1.Workflow) (bool, string) {
+		return wf.Status.Nodes.Any(func(node wfv1.NodeStatus) bool {
+			return node.Type == wfv1.NodeTypePod && node.Phase == wfv1.NodeFailed
+		}), "to have failed pod"
+	}
 )
 
 // `ToBeDone` replaces `ToFinish` which also makes sure the workflow is both complete not pending archiving.

diff --git a/test/e2e/retry_test.go b/test/e2e/retry_test.go
@@ -141,7 +141,8 @@ spec:
 `).
 		When().
 		SubmitWorkflow().
-		WaitForWorkflow(time.Second * 30).
+		WaitForWorkflow(fixtures.ToHaveFailedPod).
+		Wait(5 * time.Second).
 		Then().
 		ExpectWorkflow(func(t *testing.T, _ *metav1.ObjectMeta, status *wfv1.WorkflowStatus) {
 			if status.Phase == wfv1.WorkflowFailed {