Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rpc module to v2.0.3 #10030

Closed
MaxClercEricsson opened this issue Nov 14, 2022 · 10 comments · Fixed by #11543
Closed

Upgrade rpc module to v2.0.3 #10030

MaxClercEricsson opened this issue Nov 14, 2022 · 10 comments · Fixed by #11543
Labels
go Pull requests that update Go dependencies good first issue Good for newcomers type/dependencies PRs and issues specific to updating dependencies type/feature Feature request

Comments

@MaxClercEricsson
Copy link

Summary

The actual version of rpc is depreciated and dates back several years.

The go.mod use jcmturner/rpc.v0 v0.0.2 that is decrepeted . It would be interesting to upgrade to version jcmturner/rpc.v2 2.0.3

Proposal

Upgrade hdfs v1.1.4 to 2.3.0 it should upgrade the jcmturner/rpc version to the jcmturner/rpc.v2 2.0.3

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@MaxClercEricsson MaxClercEricsson added the type/feature Feature request label Nov 14, 2022
@terrytangyuan
Copy link
Member

Would you like to submit a PR?

@terrytangyuan terrytangyuan added the good first issue Good for newcomers label Nov 14, 2022
@SakshiT25
Copy link

SakshiT25 commented Nov 15, 2022 •
edited
Loading

Hey, I would like to work on this issue. But don't know how to start with it.

@shogohida shogohida mentioned this issue Nov 17, 2022
Closed
8 tasks
@shogohida
Copy link

shogohida commented Nov 17, 2022 •
edited
Loading

Hi @terrytangyuan, I decided to work on this issue and already made a draft pull request! How can I solve the failure of lint? I just upgraded rpc version

@terrytangyuan
Copy link
Member

You can see the diff here: https://github.com/argoproj/argo-workflows/actions/runs/3489313497/jobs/5839692005

I think you need to remove the redundant line.

@terrytangyuan
Copy link
Member

Or run go mod tidy

@shogohida
Copy link

I ran go mod tidy but it deletes the lines related to rpc.v2 v2.0.3 although I want to keep them.... Which is the redundant line you mentioned?

@terrytangyuan
Copy link
Member

You can run make lint STATIC_FILES=false to reproduce

@callmetushar123
Copy link

@terrytangyuan Hello can you assign this issue to me, I would like to work on it

@sonbui00
Copy link
Member

sonbui00 commented Aug 8, 2023 •
edited
Loading

As I check, this should upgrade gopkg.in/jcmturner/gokrb5.v5 and github.com/colinmarc/hdfs on workflow/artifacts/hdfs/

sonbui00 added a commit to sonbui00/argo-workflows that referenced this issue Aug 8, 2023
@sonbui00
fix: Upgrade hdfs and rpc module argoproj#10030
dc99775 
Signed-off-by: Son Bui <sonbv00@gmail.com>
@sonbui00 sonbui00 mentioned this issue Aug 8, 2023
Merged
terrytangyuan pushed a commit that referenced this issue Aug 9, 2023
@sonbui00
fix: Upgrade hdfs and rpc module #10030 (#11543)
68b7ea6 
Signed-off-by: Son Bui <sonbv00@gmail.com>
@terrytangyuan terrytangyuan mentioned this issue Aug 9, 2023
Closed
45 tasks
terrytangyuan pushed a commit that referenced this issue Aug 11, 2023
@sonbui00 @terrytangyuan
fix: Upgrade hdfs and rpc module #10030 (#11543)
bfbee8d 
Signed-off-by: Son Bui <sonbv00@gmail.com>
@sonbui00
Copy link
Member

This should be closed by #11543
@terrytangyuan Please help me close this.

@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Aug 20, 2023
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this issue May 9, 2024
@sonbui00 @dpadhiar
fix: Upgrade hdfs and rpc module argoproj#10030 (argoproj#11543)
14ee353 
Signed-off-by: Son Bui <sonbv00@gmail.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
go Pull requests that update Go dependencies good first issue Good for newcomers type/dependencies PRs and issues specific to updating dependencies type/feature Feature request
Projects
None yet
Milestone
No milestone
7 participants
@terrytangyuan @agilgur5 @sonbui00 @shogohida @callmetushar123 @SakshiT25 @MaxClercEricsson