Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnsconfig does not take effect in Agent pod #12824

Closed
4 tasks done
shuangkun opened this issue Mar 20, 2024 · 0 comments · Fixed by #12825
Closed
4 tasks done

Dnsconfig does not take effect in Agent pod #12824

shuangkun opened this issue Mar 20, 2024 · 0 comments · Fixed by #12825
Assignees
Labels
area/agent Argo Agent that runs for HTTP and Plugin templates area/templates/http type/bug

Comments

@shuangkun
Copy link
Member

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issue exists when I tested with :latest
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

I want to use a local dnsserver in Http template to report some info.
But dnsconfig does not take effect, the domain name cannot be resolved and the network is blocked.

what i want

I want the agent pod also use workfow dnsConfig.

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: http-template-
spec:
  entrypoint: main
  dnsPolicy: "None"
  dnsConfig:
    nameservers:
      - 100.32.2.5
      - 100.33.3.5
  templates:
    - name: main
      steps:
        - - name: get-google-homepage
            template: http
            arguments:
              parameters: [{name: url, value: "https://www.google.com"}]
    - name: http
      inputs:
        parameters:
          - name: url
      http:
        timeoutSeconds: 20 # Default 30
        url: "{{inputs.parameters.url}}"
        method: "GET" # Default GET
        headers:
          - name: "x-header-name"
            value: "test-value"
        # Template will succeed if evaluated to true, otherwise will fail
        # Available variables:
        #  request.body: string, the request body
        #  request.headers: map[string][]string, the request headers
        #  response.url: string, the request url
        #  response.method: string, the request method
        #  response.statusCode: int, the response status code
        #  response.body: string, the response body
        #  response.headers: map[string][]string, the response headers
        successCondition: "response.body contains \"google\"" # available since v3.3
        body: "test body" # Change request body

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
shuangkun added a commit to shuangkun/argo-workflows that referenced this issue Mar 20, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun added a commit to shuangkun/argo-workflows that referenced this issue Mar 20, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun added a commit to shuangkun/argo-workflows that referenced this issue Mar 22, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun added a commit to shuangkun/argo-workflows that referenced this issue Mar 22, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
agilgur5 pushed a commit that referenced this issue Mar 22, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun self-assigned this Mar 29, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 19, 2024
agilgur5 pushed a commit that referenced this issue Apr 19, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
(cherry picked from commit dbff027)
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this issue May 6, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this issue May 7, 2024
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@agilgur5 agilgur5 added the area/agent Argo Agent that runs for HTTP and Plugin templates label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent Argo Agent that runs for HTTP and Plugin templates area/templates/http type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants