refactor(ui): simplify Webpack config a bit #11594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- makes it more similar to Argo CD's [current config](https://github.com/argoproj/argo-cd/blob/bfaac2b5ac4b96c8af8158902c1b086f7ced7389/ui/src/app/webpack.config.js#L10) - using a `proxyConf` variable borrowed from there, though I thought that was a good simplification either way - `console.log` statement is very similar now, though slightly modified wording ("in" -> "for") - I was pretty confused by the `isProd= ` log before, thought it had some significance, and thought it might have an error (due to the space), but it was actually just a log statement. So make it more clear this way Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
terrytangyuan
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Simplify the Webpack config a tiny bit after having to work with it for #11593 and #11585
Modifications
proxyConfvariable borrowed from there, though I thought that was a good simplification either wayconsole.logstatement is very similar now, though slightly modified wording ("in" -> "for")isProd=log before, thought it had some significance, and thought it might have an error (due to the space), but it was actually just a log statement. So make it more clear this wayfrom:andto:to separate linesVerification
No semantic changes, just stylistic. Been using it for my local builds already, so builds definitely still pass. Just split this out as a separate, independent PR.