chore(ui): fix formatting errors in config #11629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `jest.config.js` had incorrect indentation and inconsistent keys
- `webpack.config.js` had _mostly_ double quotes, but some single quotes
- convert most to double quotes for consistency. the rest are converted in a separate PR so as to not merge conflict
- alphabetize the `DefinePlugin` substituions
- and consistently use double quoted keys for visual consistency -- this is a good bit easier on the eyes IMO
- also similar to [Argo CD config](https://github.com/argoproj/argo-cd/blob/6ca2e90b5094eba3878746fee5f2c357bfbc6cb8/ui/src/app/webpack.config.js#L66)
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
- woops, missed this until I looked at the PR diff Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
terrytangyuan
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Consistent and correct formatting:
jest.config.jshad incorrect indentation, inconsistent keys, etcwebpack.config.jshad mostly double quotes, but some single quotes and other inconsistenciesModifications
jest.config.jswebpack.config.jsDefinePluginsubstitutionsVerification
No semantic changes, just stylistic.
Build and tests continue to pass
Future Work
To format config files with
prettier