Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support OOMKilled with container-set. Fixes #10063. FOR 3.4.11 only #11757

Merged
merged 6 commits into from
Sep 6, 2023
Merged

fix: Support OOMKilled with container-set. Fixes #10063. FOR 3.4.11 only #11757

merged 6 commits into from
Sep 6, 2023

Conversation

isubasinghe
Copy link
Member

Merging in #11484

alexec and others added 6 commits September 6, 2023 20:28
@alexec @isubasinghe
fix: Support OOMKilled with container-set. Fixes argoproj#10063
8801f97 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec @isubasinghe
fix: add Term
d12de6c 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec @isubasinghe
fix: correct exit code
bbdf34e 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec @isubasinghe
fix: revert
a2e4585 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec @isubasinghe
fix: revert
7e264a7 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@isubasinghe
fix: Merge branch 'master'
d9060b4 
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@isubasinghe isubasinghe marked this pull request as ready for review September 6, 2023 10:59
@isubasinghe isubasinghe changed the title Oom killed container set 3.4.11 fix: Support OOMKilled with container-set. Fixes #10063. FOR 3.4.11 only Sep 6, 2023
@terrytangyuan terrytangyuan merged commit ee939bb into argoproj:release-3.4.11 Sep 6, 2023
2 checks passed
@terrytangyuan terrytangyuan mentioned this pull request Sep 6, 2023
Closed
5 tasks
@agilgur5 agilgur5 added type/backport Backport of an existing PR to an older release branch area/templates/container-set labels Mar 9, 2024
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
@isubasinghe @alexec @dpadhiar
fix: Support OOMKilled with container-set. Fixes argoproj#10063. FOR …
f2b5a1e 
…3.4.11 only (argoproj#11757)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
Co-authored-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
area/templates/container-set type/backport Backport of an existing PR to an older release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isubasinghe @terrytangyuan @agilgur5 @alexec