Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): add example field to argo cluster-template list. Fixes #11898 #12106

Conversation

shubhamch71
Copy link
Contributor

Fixes #11898

Motivation

Changes to support more detailed information when the user runs the argo cluster-template list command

Modifications

Added examples for some common usages of argo cluster-template list command

Verification

RUN argo cluster-template list --help

…rgoproj#11898

Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
@shubhamch71 shubhamch71 marked this pull request as ready for review October 30, 2023 17:28
@shubhamch71
Copy link
Contributor Author

@terrytangyuan @agilgur5 Please have a look and let me know if any changes are supposed to be made!!!

@agilgur5 agilgur5 self-requested a review October 30, 2023 19:37
@agilgur5 agilgur5 added area/cli The `argo` CLI area/docs Incorrect, missing, or mistakes in docs labels Oct 30, 2023
cmd/argo/commands/clustertemplate/list.go Outdated Show resolved Hide resolved
cmd/argo/commands/clustertemplate/list.go Outdated Show resolved Hide resolved
Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small modifications below to improve directness, otherwise LGTM

cmd/argo/commands/clustertemplate/list.go Outdated Show resolved Hide resolved
cmd/argo/commands/clustertemplate/list.go Outdated Show resolved Hide resolved
shubhamch71 and others added 4 commits November 3, 2023 02:08
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
…ixes argoproj#11898

Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
@terrytangyuan terrytangyuan merged commit dfbcd5f into argoproj:master Nov 3, 2023
26 of 27 checks passed
agilgur5 pushed a commit that referenced this pull request May 4, 2024
#11898 (#12106)

Signed-off-by: Shubham <83663663+shubhamch71@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
(cherry picked from commit dfbcd5f)
@agilgur5 agilgur5 changed the title docs: Add an example field to argo cluster-template list command. Fixes #11898 docs(cli): add example field to argo cluster-template list. Fixes #11898 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli The `argo` CLI area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add examples to commands' --help output
3 participants