-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delete pods in parallel to speed up retryworkflow #12419
feat: delete pods in parallel to speed up retryworkflow #12419
Conversation
b0861ee
to
5ebfed5
Compare
Co-authored-by: shuangkun <tsk2013uestc@163.com> Co-authored-by: sherwinkoo29 <sherwinkoo@163.com> Signed-off-by: shuangkun <tsk2013uestc@163.com>
5ebfed5
to
619ca05
Compare
I had no idea the Server deleted pods..that's surprising...anyway, LGTM! |
Thank you so much! |
@juliev0 that makes at least 3 of us as neither Terry nor I expected that either 😅 😕 I mentioned this in #12105 (comment), I don't think this logic should belong in the Server as it breaks the separation of duties between Controller and Server right now; this makes the Server necessary for certain operations (retry in this case). Outside of this functionality, the Server and Controller are independent, with the Server mainly signaling to the Controller (via labels) and not strictly required for any operations. Bala agreed with me there as well and multiple people have been surprised by the current behavior, so I do think we have consensus that this should be refactored |
I completely agree and wanted to make the same judgment actually. |
I'll file a tracking issue for it for now as it does require some careful refactoring. EDIT: Created #12538 |
Yes, I agree. I also had some doubts at the time, but at that time I was just focused on solving customer problems. |
Feel free to take on the issue if you'd like, otherwise I might get to it eventually (it's not the highest priority) |
I have a big worklfow. When it failed and retry, it will be slowly. Latency increases with the number of pods. Always letting my automated system(interact with argo server use https) time out.
I found that the main time spent was deleting pods.
So I want make deleting pods parallel.
Motivation
Modifications
Verification