feat: CronWorkflow/WorkflowTemplate title/description in list view #12674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: panicboat <panicboat@gmail.com>
agilgur5
reviewed
Feb 16, 2024
ui/src/app/cron-workflows/components/cron-workflow-list/cron-workflow-list.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/cron-workflows/components/cron-workflow-list/cron-workflow-list.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/workflow-templates/components/workflow-template-list/workflow-template-list.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/workflow-templates/components/workflow-template-list/workflow-template-list.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: panicboat <panicboat@gmail.com>
|
Thanks for the review. |
Signed-off-by: panicboat <panicboat@gmail.com>
jmeridth
approved these changes
Feb 17, 2024
terrytangyuan
approved these changes
Feb 18, 2024
panicboat
deleted the
panicboat/workflow-title-description-in-list-view
branch
3 tasks
|
@panicboat seems u don't show name at all if there is title? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12644 (partially, no markdown)
Motivation
Visibility would be improved if title/description could also be displayed in CronWorkflow and WorkflowTemplate
Modifications
Fixed to give priority to title and description.
Verification