Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to RBAC from installation and add notes #12680

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

rnathuji
Copy link
Contributor

These doc improvements are geared towards guiding users to RBAC details during installation and adding useful notes therein.

Motivation

These doc changes were motivated by conversations in #12391

Verification

The added notes to the Workflow RBAC page were confirmed via the following where rbac.yaml included definitions for the Role, ServiceAccount, and RoleBinding in the docs:

$ minikube start
$ kubectl create namespace argo
$ kubectl apply -n argo -f https://github.com/argoproj/argo-workflows/releases/download/v3.5.4/install.yaml
$ kubectl apply -f rbac.yaml
$ argo submit --serviceaccount hello-world --watch https://raw.githubusercontent.com/argoproj/argo-workflows/main/examples/hello-world.yaml

These doc improvements are geared towards guiding users to RBAC
details during installation and adding useful notes therein.

Signed-off-by: Ripal Nathuji <rnathuji@neoteklabs.com>
@rnathuji rnathuji marked this pull request as ready for review February 18, 2024 22:49
@terrytangyuan terrytangyuan merged commit a439f43 into argoproj:main Feb 19, 2024
15 checks passed
@terrytangyuan
Copy link
Member

Thanks!

@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Feb 20, 2024
agilgur5 pushed a commit that referenced this pull request May 4, 2024
Signed-off-by: Ripal Nathuji <rnathuji@neoteklabs.com>
(cherry picked from commit a439f43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants