chore(build): improve organization of hack/ dir
#12774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
agilgur5
changed the title
hack/ dirhack/ dir
blkperl
approved these changes
Mar 9, 2024
juliev0
approved these changes
Mar 24, 2024
|
can you resolve the conflicting file? |
- it's been a bit of a catch-all / hodgepodge, give it some organization matching the root directory names - docs scripts under `hack/docs/` - manifests scripts under `hack/manifests/` - api scripts under `hack/api/` - this also simplifies the `changed-files` list in CI as originally mentioned in its PR review - add a small README to the `hack/` dir to explain the organization - remove `hack/wfgraph.py` as unused legacy code (seems to be prior to the UI existing?) - remove `hack/parse_examples.go` from the `changed-files` list as it no longer exists after bcf5672 (I missed that, my bad) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
force-pushed
the
chore-improve-hacks-org
branch
from
5dc865e
to
59ddaf0
Compare
oh, ironically that is why I marked it as merge conflict resolved cleanly with a rebase and no changes needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12006 (comment)
Motivation
The
hack/dir been a bit of a catch-all / hodgepodge, so at least give it some organizationModifications
organize by matching the root directory names
hack/docs/hack/manifests/hack/api/changed-fileslist in CI as originally mentioned in its PR review (ci: only run jobs when relevant files have been changed #12006 (comment))hack/dir to explain the organizationremove
hack/wfgraph.pyas unused legacy code (seems to be prior to the UI existing?)remove
hack/parse_examples.gofrom thechanged-fileslist as it no longer exists after fix(docs): handlefieldsexamples withmd_in_html#12465 (I missed that, my bad)Verification
CI passes