Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to a more up-to-date Grafana dashboard #13115

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

agilgur5
Copy link
Contributor

@agilgur5 agilgur5 commented May 29, 2024

Motivation

Link to a more up-to-date Grafana dashboard.
Previous: https://grafana.com/grafana/dashboards/13927-argoworkflow-metrics/, has not received an update in 2+ years (not since early 2022)
New: https://grafana.com/grafana/dashboards/20348-argo-workflows-metrics/, has received updates in 2024

Pipekit was working on this and I was wondering where their dashboard was and then I saw it in two recent Slack threads.

Modifications

  • just update the link, nothing else

Verification

make docs passes

Notes to Reviewers / Future Work

  • disclaimer that this is Pipekit's up-to-date fork of the community one previously linked
  • ideally, we should maintain an official open-source dashboard somewhere, but in the interim, this is (much?) better than the old link
    • (also yes, source code for dashboards isn't the most readable thing, but we can work around that)
    • I imagine keeping it in this repo would be most straightforward, as changes to the metrics and dashboards can happen simultaneously, but we could also host in a separate community repo similar to the Helm charts

- this is Pipekit's fork of the community one previously linked, which hasn't received updates in a while
- ideally, we should maintain an official open-source dashboard somewhere  (I would recommend in this repo, personally), but in the interim, this is (much?) better than the old link
  - (also yes, source code for dashboards isn't the most readable thing, but we can work around that)

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@agilgur5 agilgur5 added area/docs Incorrect, missing, or mistakes in docs area/metrics labels May 29, 2024
Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Joibel Joibel merged commit 899882b into argoproj:main Jun 3, 2024
17 checks passed
@agilgur5 agilgur5 deleted the docs-update-grafana-dashboard branch June 3, 2024 16:24
@agilgur5 agilgur5 added this to the v3.4.x patches milestone Jun 6, 2024
agilgur5 added a commit that referenced this pull request Jun 6, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
(cherry picked from commit 899882b)
agilgur5 added a commit that referenced this pull request Jun 6, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
(cherry picked from commit 899882b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs area/metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants