Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Visualisation of the suspended CronWorkflows in the list. Fixes #4264 #4446

Merged
merged 1 commit into from
Nov 3, 2020
Merged

feat(ui): Visualisation of the suspended CronWorkflows in the list. Fixes #4264 #4446

merged 1 commit into from
Nov 3, 2020

Conversation

Nicwalle
Copy link
Contributor

@Nicwalle Nicwalle commented Nov 3, 2020 •
edited
Loading

Fixes #4264

Shows the suspended CronWrokflows inside the list.
Pause icon if suspended, clock icon if not (same icon as previously)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Nicwalle
Copy link
Contributor Author

Nicwalle commented Nov 3, 2020 •
edited
Loading

Does anyone mind helping me ? I don't understand what I did wrong. This is my first PR on such a big project. I just made a small UI change and the test "Ensure nothing changed" fails of course.

Thanks in advance

simster7
simster7 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simster7
Copy link
Member

simster7 commented Nov 3, 2020

@Nicwalle you need to run yarn lint inside the argo/ui/ directory.

@simster7 simster7 self-assigned this Nov 3, 2020
@Nicwalle
feat(ui): Visualisation of the suspended CronWorkflows in the list. F…
a072ede 
…ixes argoproj#4264

Signed-off-by: Nicolas van de Walle <dev.nw@walle.be>
@Nicwalle
Copy link
Contributor Author

Nicwalle commented Nov 3, 2020

@Nicwalle you need to run yarn lint inside the argo/ui/ directory.

Thanks a lot, it worked

@simster7 simster7 merged commit dedf052 into argoproj:master Nov 3, 2020
alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
@Nicwalle @alexcapras
feat(ui): Visualisation of the suspended CronWorkflows in the list. F…
f82dbe4 
…ixes argoproj#4264 (argoproj#4446)

Signed-off-by: Nicolas van de Walle <dev.nw@walle.be>
Signed-off-by: Alex Capras <alexcapras@gmail.com>
@agilgur5 agilgur5 mentioned this pull request Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees

@simster7 simster7

Labels
area/cron-workflows area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visualisation of the suspended CronWorkflows in the list
4 participants
@Nicwalle @CLAassistant @simster7 @agilgur5