Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update old buildkit version in buildkit-template.yaml #7501

Closed
wants to merge 6 commits into from

Conversation

cod-r
Copy link
Contributor

@cod-r cod-r commented Jan 4, 2022

I spent a few hours trying to figure out why the example in buildkit-template.yaml was not working with a private insecure docker registry.
The problem was a bug in the moby/buildkit version used in this example. I updated the version so other people waste time like I did.

I spent a few hours trying to figure out why this example was not working with a private docker registry.
The problem was a bug in the moby/buildkit version used in this example. I updated the version so other people waste time figuring out why it's not working.
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the checks. It would also be great to link to the issue in the older version of buildkit.

@cod-r cod-r changed the title update old buildkit version in buildkit-template.yaml fix: update old buildkit version in buildkit-template.yaml Jan 6, 2022
@cod-r
Copy link
Contributor Author

cod-r commented Jan 6, 2022

Please fix the checks. It would also be great to link to the issue in the older version of buildkit.

This is the pr that solved the insecure registry issue: moby/moby#40814
I can't figure out in what version of moby/buildkit was this introduced though, but it was definitely not working in 0.7.2 and working in 0.9.3

cod-r and others added 2 commits January 6, 2022 14:11
I spent a few hours trying to figure out why this example was not working with a private docker registry.
The problem was a bug in the moby/buildkit version used in this example. I updated the version so other people waste time figuring out why it's not working.

Signed-off-by: Codrut Panea <codrut.panea@esolutions.ro>
…o patch-1

Signed-off-by: Codrut Panea <codrut.panea@esolutions.ro>
terrytangyuan and others added 3 commits January 6, 2022 15:31
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Codrut Panea <codrut.panea@esolutions.ro>
I spent a few hours trying to figure out why this example was not working with a private docker registry.
The problem was a bug in the moby/buildkit version used in this example. I updated the version so other people waste time figuring out why it's not working.

Signed-off-by: Codrut Panea <codrut.panea@esolutions.ro>
@cod-r cod-r closed this Jan 6, 2022
@cod-r cod-r deleted the patch-1 branch January 6, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants