Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better error message for sync operations #336

Merged
merged 6 commits into from
Oct 21, 2021

Conversation

pasha-codefresh
Copy link
Member

Signed-off-by: pashavictorovich pavel@codefresh.io

Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #336 (3b4a500) into master (33f542d) will increase coverage by 0.55%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   48.61%   49.16%   +0.55%     
==========================================
  Files          41       41              
  Lines        3314     3297      -17     
==========================================
+ Hits         1611     1621      +10     
+ Misses       1544     1518      -26     
+ Partials      159      158       -1     
Impacted Files Coverage Δ
pkg/sync/sync_context.go 71.52% <86.66%> (+0.31%) ⬆️
pkg/sync/sync_tasks.go 92.00% <100.00%> (+0.33%) ⬆️
pkg/health/health_hpa.go 82.89% <0.00%> (+0.22%) ⬆️
pkg/health/health_ingress.go 100.00% <0.00%> (+70.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f542d...3b4a500. Read the comment docs.

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit bc9ce57 into argoproj:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants