fix(princing-page): fix hydratation #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregberge
requested changes
Jun 2, 2024
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
jsfez
force-pushed
the
rework-princing-page
branch
from
9824e99
to
61a3f79
Compare
jsfez
force-pushed
the
rework-princing-page
branch
from
61a3f79
to
237d353
Compare
gregberge
requested changes
Jun 3, 2024
jsfez
force-pushed
the
rework-princing-page
branch
from
8981ec9
to
aab6723
Compare
jsfez
force-pushed
the
rework-princing-page
branch
2 times, most recently
from
2057b30
to
0eb6218
Compare
gregberge
requested changes
Jun 11, 2024
app/pricing/FormattersComponents.tsx
Outdated
| ); | ||
|
|
||
| React.useEffect(() => { | ||
| setFormatter(new Intl.NumberFormat(undefined, optionsRef.current)); |
There was a problem hiding this comment.
It would be much more efficient to store value in state because if locale produces the same it will avoid a re-render.
There was a problem hiding this comment.
I don't understand how to do that and I don't want to delay the PR. As the efficiency improvement has no value here, I'll ignore it.
jsfez
force-pushed
the
rework-princing-page
branch
from
e453157
to
8c14012
Compare
gregberge
requested changes
Jun 11, 2024
app/pricing/FormattersComponents.tsx
Outdated
| ); | ||
|
|
||
| React.useEffect(() => { | ||
| setFormatter(() => new Intl.NumberFormat(undefined, optionsRef.current)); |
There was a problem hiding this comment.
As I said it's inneficient to set the formatter and not the value.
There was a problem hiding this comment.
- Greg: inefficient
- Jeremy: NIT (nitpicking)
- Greg: inefficient
Well, well 🐳
jsfez
force-pushed
the
rework-princing-page
branch
from
8c14012
to
79fceea
Compare
jsfez
force-pushed
the
rework-princing-page
branch
from
79fceea
to
50db64f
Compare
gregberge
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.