Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added onDisconnect and applied when websoket disconnects #43

Merged
merged 1 commit into from
Aug 19, 2016

Conversation

grahambrown11
Copy link
Collaborator

Hi @l3nz

A while back you added a RestException when the websocket is disconnected - Issue #26
So the code added was commented out with some refactoring...
ari4java/classes/ch/loway/oss/ari4java/tools/AriAsyncHandler.java

    @Override
    public void onResponseReceived() {
        //this.callback.onFailure(new RestException("Asterisk WS is disconnected. Please retry."));
    }

I've added another method to the HttpResponseHandler - onDisconnect to avoid confusion
I've sent a pull request - if you wouldn't mind checking if I've not missed anything and merging, I need to deploy this soon - thanks

@l3nz
Copy link
Collaborator

l3nz commented Jul 11, 2016

Looks sane to me. Maybe, while you are at it - why not adding an option to automagically reconnect?

@l3nz
Copy link
Collaborator

l3nz commented Aug 17, 2016

Hi,
do you want to redo the patch with the autoreconnect or should I merge this one in first?

@grahambrown11
Copy link
Collaborator Author

Sorry, wanted to look at the auto reconnect, but haven't had time, will definitely look into it. Up to you if you want to wait a week or 2 or merge this...

@l3nz
Copy link
Collaborator

l3nz commented Aug 18, 2016

Let's do this - I'm merging but filing a new bug for the autoreconnect, and you will submit it when you have the time, ok? :-)

@l3nz l3nz mentioned this pull request Aug 19, 2016
@l3nz
Copy link
Collaborator

l3nz commented Aug 19, 2016

I created a new issue #46 and I'm merging 👍

@l3nz l3nz closed this Aug 19, 2016
@l3nz l3nz reopened this Aug 19, 2016
@l3nz l3nz merged commit 69f373f into ari4java:master Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants