feat(reakit-system): Replace useCompose by useComposeOptions on createHook

[diegohaz]

useCompose kind of breaks the encapsulated composition approach of createHook. This PR replaces it by useComposeOptions, which will be called after useProps and return options instead of calling the composed hooks directly.

Also, it changes the order that composed useOptions are called. Before, they were being called after the current hook useProps, which didn't compose so well as it wouldn't have access to options modified by the composed hooks. Now composed useOptions are called right after the current hook useOptions, but before useProps. The current hook useProps now will receive the options after they get proccessed by all composed hooks. It's necessary so the new Id module proposed on #492 will be able to pass a default id or baseId option to other hooks composing it.

Does this PR introduce a breaking change?

There's no breaking changes on the main package (reakit), but reakit-system's createHook won't accept useCompose anymore.

• createHook's useCompose has been replaced by useComposeOptions.

  Before:

  const useHook = createHook({
    useCompose(options, htmlProps) {
      return useComposedHook({ ...options, newOption: true }, htmlProps);
    }
  });

  After:

  const useHook = createHook({
    useComposeOptions(options) {
      return { ...options, newOption: true };
    }
  });

[codecov]

Codecov Report

Merging #493 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   95.43%   95.42%   -0.01%     
==========================================
  Files         100      100              
  Lines        1490     1487       -3     
  Branches      472      472              
==========================================
- Hits         1422     1419       -3     
  Misses         68       68

Impacted Files	Coverage Δ
packages/reakit/src/Menu/Menu.tsx	100% <ø> (ø)	⬆️
packages/reakit/src/Form/FormInput.ts	100% <100%> (ø)	⬆️
packages/reakit/src/Form/FormCheckbox.ts	92.85% <100%> (ø)	⬆️
packages/reakit/src/Menu/MenuDisclosure.ts	98% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d87e99...ba61f5d. Read the comment docs.

[ariakit-bot]

Deploy preview for reakit ready!

Built with commit ba61f5d

https://deploy-preview-493--reakit.netlify.com