runtime cleanup #117
runtime cleanup #117
Conversation
|
I kinda liked to have the transpiler separated.... 😕 |
| @@ -1,6 +1,7 @@ | |||
| var parser = require("./parser/index"); | |||
| var treebuilder = require("./treebuilder/index"); | |||
| var jsgenerator = require("./jsgenerator/index"); | |||
| var transpiler = require("../transpiler"); | |||
There was a problem hiding this comment.
Build is failing here (see https://travis-ci.org/ariatemplates/hashspace/builds/22138228):
Running "atpackager:runtime" (atpackager) task
>> hsp/compiler/compiler.js depends on ../transpiler which cannot be found.
Warning: There were 1 error(s) while packaging.� Use --force to continue.
Should be replaced by var transpiler = require("../transpiler/index");
There was a problem hiding this comment.
Then we need to also include uglify-js in the noder build... I am working on this...
|
Well, we all agree that we should introduce compilation options (e.g. to say if we want compile in 'commonJS' or 'globalVariable' mode) - so one of the option should be done for the desactivate transpiler. Btw. I added the transpiler to the compiler as I want to keep things simple - and having to call a compiler is already complex enough, so I would prefer to keep only one compilation step (but of course if some want to use more fine-tuned build scripts they should be allowed to...) |
This PR removes some runtime methods that were added for the playground application and that are now obsolete. It also pushes the transpiler in the compiler, as it doesn't make sense to keep them separate - especially if the playground shows samples with the transpiler (playground doc has also been updated accordingly btw.)