Update 1.1.0 #6
Merged
Update 1.1.0 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Apply arichr code style * Simplify test cases * Create dev-requrements.txt (for snyk) * Update README.md * Rewrite descriptions
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return b''.join((path, b'?', query, const.EOL)) | ||
|
|
||
| def parse_response(self, resp: ByteString, encoding: str = 'utf-8') -> Union[list[Item], list, ByteString]: | ||
| def parse_response(self, resp: ByteString) -> Union[list[Item], list, ByteString]: |
There was a problem hiding this comment.
Line too long (86 > 79 characters)
| @@ -39,8 +40,8 @@ def parse(cls, client: Item, raw: ByteString, encoding: str = 'utf-8') -> Union[ | |||
| raw = raw.decode(encoding) | |||
| parts = raw[1:].split(const.SEPARATOR) | |||
| if len(parts) < 4: | |||
| raise ValueError('Broken response or a file.') | |||
| except (UnicodeDecodeError, ValueError): | |||
| raise ValueError('The server returned a file or a broken response.') | |||
There was a problem hiding this comment.
Line too long (84 > 79 characters)
| @@ -21,7 +22,7 @@ class Item: | |||
| port: int = 70 | |||
|
|
|||
| @classmethod | |||
| def parse(cls, client: Item, raw: ByteString, encoding: str = 'utf-8') -> Union[Item, None]: | |||
| def parse(cls, client: Gopher, raw: ByteString, encoding: str = 'utf-8') -> Union[Item, None]: | |||
There was a problem hiding this comment.
Line too long (98 > 79 characters)
| 'Topic :: Software Development :: Libraries', | ||
| 'Topic :: Software Development :: Libraries :: Python Modules', | ||
| ), | ||
| keywords='gopher, gophient, client, python3, gopher-client, gopherspace, module, library', |
There was a problem hiding this comment.
Line too long (94 > 79 characters)
|
|
||
| Gophient is a library for connecting to Gopher servers. By using it you can: | ||
| Gophient is client library for the Gopherspace. It doesn't require any dependencies and is easy to use. |
|
Code Climate has analyzed commit 043b596 and detected 11 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit is more about improving code style, but it also changes:
gophient.types.Gopher.request()should be invoked:Also: