Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added conditional download resume feature #179

Merged
merged 4 commits into from
Oct 3, 2022
Merged

added conditional download resume feature #179

merged 4 commits into from
Oct 3, 2022

Conversation

joanjeremiah
Copy link
Contributor

I have implemented 'Download Resume' feature . Just let me know if any changes required

arifszn
arifszn requested changes Oct 2, 2022
View reviewed changes
Copy link
Owner

@arifszn arifszn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. A small modification is required. Also, please update the readme.

src/components/avatar-card/index.jsx Outdated Show resolved Hide resolved
joanjeremiah
joanjeremiah commented Oct 2, 2022
View reviewed changes
Copy link
Contributor Author

@joanjeremiah joanjeremiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the suggested changes in the 'Download Resume' button and also update the readme markdown.

@arifszn arifszn linked an issue Oct 3, 2022 that may be closed by this pull request
Add option to download resume #131
Closed
@arifszn
Copy link
Owner

arifszn commented Oct 3, 2022

Looks good. Can you please run the command npm run lint:fix:? Also, are you participating in hacktoberfest? Do I need to do anything after merging it so that it counts against you?

@joanjeremiah
Copy link
Contributor Author

Looks good. Can you please run the command npm run lint:fix:? Also, are you participating in hacktoberfest? Do I need to do anything after merging it so that it counts against you?

I have run the lint fix command. Do I need to make another pull request ? And yes I am participating in hacktoberfest . I believe simply merging my pull request is enough for it to count . I will let you know if it was not taken into the count.

@joanjeremiah
Copy link
Contributor Author

I don't know why the run prettier command fails . Please let me know what I need to do.

@arifszn
Copy link
Owner

arifszn commented Oct 3, 2022

I don't know why the run prettier command fails . Please let me know what I need to do.

Maybe try running npm run prettier:fix.

@arifszn arifszn merged commit 1dec29a into arifszn:main Oct 3, 2022
@joanjeremiah
Copy link
Contributor Author

I don't know why the run prettier command fails . Please let me know what I need to do.

Maybe try running npm run prettier:fix.

I tried running the command and it works !

@arifszn arifszn linked an issue Oct 11, 2022 that may be closed by this pull request
Add loading indicator for Download Resume button #188
Closed
@arifszn arifszn removed a link to an issue Oct 11, 2022
Add loading indicator for Download Resume button #188
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arifszn arifszn arifszn requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to download resume
2 participants
@joanjeremiah @arifszn