Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase external projects #197

Merged
merged 8 commits into from
Jan 3, 2023
Merged

Showcase external projects #197

merged 8 commits into from
Jan 3, 2023

Conversation

arifszn
Copy link
Owner

@arifszn arifszn commented Oct 12, 2022

Extension of #194.
Close #182.

@arifszn arifszn self-assigned this Oct 12, 2022
@arifszn arifszn marked this pull request as draft October 12, 2022 09:13
@csarnataro
Copy link
Contributor

Hi, I noticed that this PR hasn't been merged because of trivial linting issues (unused variables).
E.g.

Error:   2:10  error  'AiOutlineStar' is defined but never used  no-unused-vars

I would love to use the showcase feature. Maybe @micheldore can you have a look at those issues?

@arifszn
Copy link
Owner Author

arifszn commented Dec 30, 2022

Hi, I noticed that this PR hasn't been merged because of trivial linting issues (unused variables). E.g.

Error:   2:10  error  'AiOutlineStar' is defined but never used  no-unused-vars

I would love to use the showcase feature. Maybe @micheldore can you have a look at those issues?

I am planning to complete this actually but did not find the proper time. I will take a look again soon. Meanwhile, if you are interested to contribute to this project, there are some open issues you can start.

@arifszn arifszn force-pushed the showcase branch 2 times, most recently from 7d65efc to 6b31bf8 Compare January 3, 2023 11:06
@arifszn arifszn marked this pull request as ready for review January 3, 2023 11:10
@arifszn arifszn merged commit 4eeb320 into main Jan 3, 2023
@arifszn arifszn deleted the showcase branch January 3, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate Repos and Projects sections
3 participants