Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mastodon social link #266

Merged
merged 5 commits into from
Feb 14, 2023

Conversation

csarnataro
Copy link
Contributor

Added a configuration for Mastodon social, updated the list of social link. Updated README accordingly.

Added a configuration for Mastodon social, updated the list of social link.
Updated README accordingly.
@arifszn
Copy link
Owner

arifszn commented Dec 31, 2022

Haven't heard of mastodon before but sounds promising as a new social network.

Seems the user would need to add the verification link manually. Sounds a bit complex in terms of the general user. That's why not planning to add this currently. The goal of this project is to make a portfolio builder as easy as possible. That's why we try to keep features simple.

@arifszn arifszn closed this Dec 31, 2022
@arifszn
Copy link
Owner

arifszn commented Dec 31, 2022

I intend to sign up for Mastodon and might reopen this PR.

@csarnataro
Copy link
Contributor Author

csarnataro commented Jan 1, 2023

I see, and it makes sense.
Regarding the verification link, it's an optional feature, a user doesn't need to implement it to have an account on Mastodon.
Just to let you know, I have implemented the Mastodon link in my fork at csarnataro.github.io

Again, thank you for this project.

@arifszn
Copy link
Owner

arifszn commented Feb 4, 2023

Let's add this. But remove the verification link. An advance user should be able to figure that out by himself.

@arifszn arifszn reopened this Feb 4, 2023
@csarnataro
Copy link
Contributor Author

Hi @arifszn
I've removed the verification link instructions from the README file.

@arifszn arifszn merged commit b06ddf9 into arifszn:main Feb 14, 2023
apetl pushed a commit to apetl/apetl.github.io that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants